If you don't give the crab a brackish environment, his lifespan will be very short. If you put the goldfish in brackish water, being a freshwater species, his lifespan will most likely be considerably shortened.
As brack-man explained, putting in aquarium salt does not make brackish water, no matter what the ill-informed writer of that article said.
Brackish is between the fresh water of a river and the marine water of the open sea. Crabs live on beaches and in salt marshes (mud flats), so you can see that their water would be a mixture of marine and fresh. Instant Ocean marine salt has more minerals in it than just salt. If you use aquarium salt, your crab will be missing out on many important elements in his environment.
Your crab also needs a land area. You would probably need to lower the water level in your tank to accomodate this. That would effectively decrease the volume of water for your goldies. One goldie needs ten to twenty gallons of water to live in. If you have two in somewhat less than twelve (after adapting the tank for the crab), you will have even more water quality issues than you have now.
Putting them together in any environment is not fair to either one.
Hopefully, you can get a bigger tank for your goldies, or rehome them and get a fish which really does like brackish conditions, like a molly, maybe, for your 12g. (Anyone... correct me if I'm wrong, please?)